Upgrades ESLint to Version 9 #2958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades ESLint to Version 9 (Flat file config), and Prettier to latest. No runtime code was changed for this PR.
How to review
Due to the nature of linting tools, this is a massive PR and it is easier to review by looking at the atomic commits, in order:
1. Remove NPS as the eslint task runner commit: c0c935
We are migrating away from NPS as a task runner and this commit removes eslint from the NPS scripts and directly executes it from root. This allows ESLint to manage its own parallelism and execute significantly faster and with less resources.
2. Upgrade ESLint to Version 9 commit: f45fdc
FormidableLabs/eslintsince that is deprecatedeslint-plugin-importwhich does not have a fully compatible ESLint9 version yet3. Resolve lint warnings in packages commit: 456a8
no-process-exit,max-statements,max-len, andcomplexityas providing low valuemax-nested-callbacksnow properly recognizes chained functions, so the disable comments have been removedreact/no-did-mount-set-stateis deprecated and no longer recommended@typescript-eslint/ban-typesis deprecated and has been replaced by@typescript-eslint/no-unsafe-functions@typescript-eslint/no-empty-interfaceis deprecated and has been replaced by@typescript-eslint/no-empty-object-type@typescript-eslint/no-empty-functionis deprecated and no longer recommended4. Resolve lint warnings in demos commit: 47d34c
5. Resolve lint warnings in Storybook commit: 6f3f7a
6. Resolve lint warnings in build scripts commit: ed209b
7. Resolve lint warnings in website commit: 59503
8. Remove unneccessary files from wireit deps commit: 7d5d8